From 2ad7039e7c6ee1da892cc00b9d311c15cda91349 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Thu, 24 Mar 2022 19:48:08 +0100 Subject: [PATCH] qemu: Don't ignore XMLParseAllowReboot() errors The function may fail and report an error, in which case we should not just continue as if nothing happened. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 820a6a8a61..fe00c6f25b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3106,7 +3106,8 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, priv->chardevStdioLogd = virXPathBoolean("boolean(./chardevStdioLogd)", ctxt) == 1; - qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot); + if (qemuDomainObjPrivateXMLParseAllowReboot(ctxt, &priv->allowReboot) < 0) + goto error; qemuDomainObjPrivateXMLParsePR(ctxt, &priv->prDaemonRunning); -- 2.47.2