From 2bc2b3b102488609d9d62e4aaf84bf73b21d500e Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Fri, 12 Jan 2024 10:42:13 +0100 Subject: [PATCH] 1524920 COPY_INSTEAD_OF_MOVE --- pdns/recursordist/syncres.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc index 171eb0a9e3..7fd669d3cb 100644 --- a/pdns/recursordist/syncres.cc +++ b/pdns/recursordist/syncres.cc @@ -2270,7 +2270,7 @@ void SyncRes::getBestNSFromCache(const DNSName& qname, const QType qtype, vector vector selected; selected.reserve(s_maxnsperresolve); std::sample(nsVector.cbegin(), nsVector.cend(), std::back_inserter(selected), s_maxnsperresolve, pdns::dns_random_engine()); - nsVector = selected; + nsVector = std::move(selected); } bestns.reserve(nsVector.size()); -- 2.47.2