From 2c49a268e2905c754aebe84842e17563eb43837b Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Thu, 15 Sep 2022 15:26:46 +0200 Subject: [PATCH] test: do not output non ascii character The unit test for content |aa bz| transforms in place the string str to replace the 2 characters aa by one character 0xaa Then, when z is not recognized as a valid hexadeicmal character, the whole modified string is printed out, inclusing the non-ascii 0xaa Ticket: #5558 (cherry picked from commit b281199e9aa1d2d66ac35d1f53358afca8c44a13) --- src/detect-content.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/detect-content.c b/src/detect-content.c index 3609c905d7..d0c71755fb 100644 --- a/src/detect-content.c +++ b/src/detect-content.c @@ -165,8 +165,10 @@ int DetectContentDataParse( // SCLogDebug("space as part of binary string"); } else if (str[i] != ',') { - SCLogError(SC_ERR_INVALID_SIGNATURE, "Invalid hex code in " - "content - %s, hex %c. Invalidating signature.", str, str[i]); + SCLogError(SC_ERR_INVALID_SIGNATURE, + "Invalid hex code in " + "content - %s, hex %c. Invalidating signature.", + contentstr, str[i]); goto error; } } else if (escape) { -- 2.47.2