From 2cef16f5c3e19f23d0d10435a995f240eb3552fb Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Sun, 4 Nov 2012 02:42:43 +0000 Subject: [PATCH] Only deref a reserved gateway session if we actually reserved one Its perfectly acceptable to have a gateway session unreserved when we go to first allocate one. Unreffing the reserved gateway session - when its NULL - will result in an assertion error. This problem was caught by the Asterisk Test Suite (once we had enough of the debugging flags enabled) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@375797 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- res/res_fax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/res/res_fax.c b/res/res_fax.c index 3bec8b6665..836973829f 100644 --- a/res/res_fax.c +++ b/res/res_fax.c @@ -2549,7 +2549,9 @@ static int fax_gateway_start(struct fax_gateway *gateway, struct ast_fax_session } /* release the reference for the reserved session and replace it with * the real session */ - ao2_ref(gateway->s, -1); + if (gateway->s) { + ao2_ref(gateway->s, -1); + } gateway->s = s; gateway->token = NULL; -- 2.47.2