From 2d055ed1f7084a9f10a7122f5d485c51f9db81bc Mon Sep 17 00:00:00 2001 From: Jeff Lucovsky Date: Fri, 10 Jul 2020 08:16:06 -0400 Subject: [PATCH] detect: Correct Coverity REVERSE_INULL issue This commit corrects the "Null pointer dereferences" issue (CID 1465221). --- src/detect-engine.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/detect-engine.c b/src/detect-engine.c index b984e587ca..a5f0d9225b 100644 --- a/src/detect-engine.c +++ b/src/detect-engine.c @@ -767,6 +767,10 @@ static void DetectBufferTypeFreeFunc(void *data) { DetectBufferType *map = (DetectBufferType *)data; + if (map == NULL) { + return; + } + /* Release transformation option memory, if any */ for (int i = 0; i < map->transforms.cnt; i++) { if (map->transforms.transforms[i].options == NULL) @@ -779,9 +783,8 @@ static void DetectBufferTypeFreeFunc(void *data) } sigmatch_table[map->transforms.transforms[i].transform].Free(NULL, map->transforms.transforms[i].options); } - if (map != NULL) { - SCFree(map); - } + + SCFree(map); } static int DetectBufferTypeInit(void) -- 2.47.2