From 2d1d7d00d8785ae9ad27800ae331601f4ebc3d25 Mon Sep 17 00:00:00 2001
From: Nicolas Coden <nicolas@ncoden.fr>
Date: Sat, 4 Aug 2018 20:01:27 +0200
Subject: [PATCH] refactor: improve Orbit "_updateBullets" readibility

---
 js/foundation.orbit.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/js/foundation.orbit.js b/js/foundation.orbit.js
index 9d84d4308..bfcf1ab08 100644
--- a/js/foundation.orbit.js
+++ b/js/foundation.orbit.js
@@ -383,8 +383,10 @@ class Orbit extends Plugin {
   * @param {Number} idx - the index of the current slide.
   */
   _updateBullets(idx) {
-    var $oldBullet = this.$element.find(`.${this.options.boxOfBullets}`)
-      .find('.is-active').removeClass('is-active').blur();
+    var $oldBullet = this.$bullets.filter('.is-active');
+    var $newBullet = this.$bullets.eq(idx);
+    $oldBullet.removeClass('is-active').blur();
+    $newBullet.addClass('is-active');
 
     var activeStateDescriptor = $oldBullet.children('[data-slide-active-label]').last();
     if (!activeStateDescriptor.length) {
@@ -392,8 +394,6 @@ class Orbit extends Plugin {
       activeStateDescriptor.attr('data-slide-active-label', '');
     }
 
-    activeStateDescriptor.detach();
-    $newBullet = this.$bullets.eq(idx).addClass('is-active').append(activeStateDescriptor);
   }
 
   /**
-- 
2.47.2