From 2db3f8cf8b432f0c39b619dd92269a732256449e Mon Sep 17 00:00:00 2001 From: Neil Horman Date: Thu, 11 Sep 2025 15:39:44 -0400 Subject: [PATCH] remove afalg tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We have a specific test suite that exercizes the afalg engine, that is becoming useless with engine removal. I had considered that we should perhaps convert this into a provider, but having looked at the engine itself, it only offers implementations for AES-128, AES-192 and AES-256. Given that the default provider offers these algorithms with hardware acceleration via the aesni instruction set (or comparable instructions on non-x86 arches), it seems like the only advantage the afalg engine offers is acceleration of these ciphers on platforms that have off-cpu accelerators and no cpu based acceleration support. given that: a) Most cpus have instruction based acceleration b) We don't test with any platforms that use external accelerators It seems like alot of investment to get no real advantage, so just remove the test, allowing us to delete the engine entirely in another PR. Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz Reviewed-by: Saša Nedvědický Reviewed-by: Eugene Syromiatnikov Reviewed-by: Matt Caswell Reviewed-by: Norbert Pocs (Merged from https://github.com/openssl/openssl/pull/29305) --- test/recipes/30-test_afalg.t | 21 --------------------- 1 file changed, 21 deletions(-) delete mode 100644 test/recipes/30-test_afalg.t diff --git a/test/recipes/30-test_afalg.t b/test/recipes/30-test_afalg.t deleted file mode 100644 index 572a847511a..00000000000 --- a/test/recipes/30-test_afalg.t +++ /dev/null @@ -1,21 +0,0 @@ -#! /usr/bin/env perl -# Copyright 2015-2020 The OpenSSL Project Authors. All Rights Reserved. -# -# Licensed under the Apache License 2.0 (the "License"). You may not use -# this file except in compliance with the License. You can obtain a copy -# in the file LICENSE in the source distribution or at -# https://www.openssl.org/source/license.html - -use strict; -use OpenSSL::Test qw/:DEFAULT/; -use OpenSSL::Test::Utils; - -my $test_name = "test_afalg"; -setup($test_name); - -plan skip_all => "$test_name not supported for this build" - if disabled("afalgeng"); - -plan tests => 1; - -ok(run(test(["afalgtest"])), "running afalgtest"); -- 2.47.3