From 2e93441697ae09d6ae805b24b3b5453af168282a Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 30 Nov 2021 11:49:24 +0100 Subject: [PATCH] qemuProcessRefreshDisks: Automatically free GHashTable and refactor cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Martin Kletzander --- src/qemu/qemu_process.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1edec1a5bb..f9be19d213 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8310,8 +8310,7 @@ qemuProcessRefreshDisks(virQEMUDriver *driver, { qemuDomainObjPrivate *priv = vm->privateData; bool blockdev = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV); - GHashTable *table = NULL; - int ret = -1; + g_autoptr(GHashTable) table = NULL; size_t i; if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) == 0) { @@ -8320,7 +8319,7 @@ qemuProcessRefreshDisks(virQEMUDriver *driver, } if (!table) - goto cleanup; + return -1; for (i = 0; i < vm->def->ndisks; i++) { virDomainDiskDef *disk = vm->def->disks[i]; @@ -8351,11 +8350,7 @@ qemuProcessRefreshDisks(virQEMUDriver *driver, diskpriv->tray = info->tray; } - ret = 0; - - cleanup: - virHashFree(table); - return ret; + return 0; } -- 2.47.2