From 329ed9f91fbc1b9ab34b5acee2e18dd620cd4d12 Mon Sep 17 00:00:00 2001 From: Roland McGrath Date: Mon, 9 Mar 2009 20:49:53 -0700 Subject: [PATCH] __libdwfl_find_build_id optimization nit --- libdwfl/ChangeLog | 3 +++ libdwfl/dwfl_module_build_id.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index ef7182665..d420e3c9d 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,5 +1,8 @@ 2009-03-09 Roland McGrath + * dwfl_module_build_id.c (__libdwfl_find_build_id): Move SHSTRNDX + variable to outer scope, so we cache it for the loop. + * relocate.c (__libdwfl_relocate_value): Add MOD->main.bias to sh_addr. 2009-02-12 Roland McGrath diff --git a/libdwfl/dwfl_module_build_id.c b/libdwfl/dwfl_module_build_id.c index 5d196a9d9..f3fcc190e 100644 --- a/libdwfl/dwfl_module_build_id.c +++ b/libdwfl/dwfl_module_build_id.c @@ -97,6 +97,7 @@ int internal_function __libdwfl_find_build_id (Dwfl_Module *mod, bool set, Elf *elf) { + size_t shstrndx = SHN_UNDEF; int result = 0; Elf_Scn *scn = elf_nextscn (elf, NULL); @@ -132,7 +133,6 @@ __libdwfl_find_build_id (Dwfl_Module *mod, bool set, Elf *elf) if (likely (shdr != NULL) && shdr->sh_type == SHT_NOTE) { /* Determine the right sh_addr in this module. */ - size_t shstrndx = SHN_UNDEF; GElf_Addr vaddr = 0; if (!(shdr->sh_flags & SHF_ALLOC) || __libdwfl_relocate_value (mod, elf, &shstrndx, -- 2.47.2