From 32eae6fd31ca610f3ba6e7476e79b3c464e25c68 Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Fri, 19 Nov 2021 16:20:25 +0100 Subject: [PATCH] util: Report errors in all code paths in virPolkitAgentCreate MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Martin Kletzander Reviewed-by: Ján Tomko --- src/util/virpolkit.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index ebe131dc51..201cf4a33f 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -180,8 +180,11 @@ virPolkitAgentCreate(void) int outfd = STDOUT_FILENO; int errfd = STDERR_FILENO; - if (!isatty(STDIN_FILENO)) + if (!isatty(STDIN_FILENO)) { + virReportError(VIR_ERR_SYSTEM_ERROR, "%s", + _("Cannot start polkit text agent without a tty")); goto error; + } if (virPipe(pipe_fd) < 0) goto error; @@ -205,8 +208,11 @@ virPolkitAgentCreate(void) pollfd.fd = pipe_fd[0]; pollfd.events = POLLHUP; - if (poll(&pollfd, 1, -1) < 0) + if (poll(&pollfd, 1, -1) < 0) { + virReportSystemError(errno, "%s", + _("error in poll call")); goto error; + } return agent; -- 2.47.2