From 33a09a5f2a74a06089081fc4dc499d979d78265e Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 25 Oct 2018 13:49:49 +0200 Subject: [PATCH] MINOR: stream-int: don't needlessly call tasklet_wakeup() in stream_int_chk_snd_conn() This one was added by commit 53216e7db ("MEDIUM: connections: Don't directly mess with the polling from the upper layers.") after the removal of the conditional cs_want_send() call. But after analysis it turned out that it's not needed since the si_cs_send() call will either succeed or subscribe. --- src/stream_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stream_interface.c b/src/stream_interface.c index 4fd23c3a4d..e7ba722886 100644 --- a/src/stream_interface.c +++ b/src/stream_interface.c @@ -995,7 +995,7 @@ static void stream_int_chk_snd_conn(struct stream_interface *si) if (!(si->wait_event.wait_reason & SUB_CAN_SEND) && co_data(si_oc(si))) si_cs_send(cs); - tasklet_wakeup(si->wait_event.task); + if (cs->flags & CS_FL_ERROR || cs->conn->flags & CO_FL_ERROR) { /* Write error on the file descriptor */ si->flags |= SI_FL_ERR; -- 2.39.5