From 33fc8b0d95bb05718e93476e7aa0cd6e65b0062a Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 25 Apr 2024 13:30:10 +0200 Subject: [PATCH] core: fix assertions in manager_dispatch_user_lookup_fd() assert_se() should not be used here, these checks are paranoia only and have no side-effect after all. hence fix this to use assert(), or in fact ASSERT_PTR() --- src/core/manager.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 11a81139868..89c80821b94 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -4776,13 +4776,12 @@ static int manager_dispatch_user_lookup_fd(sd_event_source *source, int fd, uint char unit_name[UNIT_NAME_MAX+1]; } _packed_ buffer; - Manager *m = userdata; + Manager *m = ASSERT_PTR(userdata); ssize_t l; size_t n; Unit *u; - assert_se(source); - assert_se(m); + assert(source); /* Invoked whenever a child process succeeded resolving its user/group to use and sent us the * resulting UID/GID in a datagram. We parse the datagram here and pass it off to the unit, so that -- 2.47.3