From 34a18f5a79bf7eca58e55aff3e1fe69468292d0f Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Tue, 20 Jun 2023 15:35:34 +0300 Subject: [PATCH] dict-redis: Fix error handling for failed synchronous commits An error was logged if a synchronous commit failed, but the commit callback was called with success instead of failure. --- src/lib-dict/dict-redis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib-dict/dict-redis.c b/src/lib-dict/dict-redis.c index 94ba301aa8..82dcf195e7 100644 --- a/src/lib-dict/dict-redis.c +++ b/src/lib-dict/dict-redis.c @@ -700,7 +700,9 @@ redis_transaction_commit(struct dict_transaction_context *_ctx, bool async, i_free(ctx); return; } - (void)redis_wait(dict); + ctx->error = i_strdup(redis_wait(dict)); + if (ctx->error != NULL) + result.ret = DICT_COMMIT_RET_FAILED; } else { callback(&result, context); } -- 2.47.3