From 368e8e302d7eb3f44e7875b4d880f68dd7cdd2fc Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Fri, 20 Apr 2018 22:39:39 +0200 Subject: [PATCH] chore: improve GitHub pull request template This template was generated by https://www.talater.com/open-source-templates/#/ and modified according to our own CONTRIBUTION.md guidelines. --- .github/PULL_REQUEST_TEMPLATE.md | 40 ++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d41473f05..b7e45ce31 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,38 @@ -Before submitting a pull request, make sure it's targeting the right branch: + -- For the latest version, use `develop`. -- For bug fixes incompatible with `develop`, use the support branch of the latest compatible and supported version `support/6.x`. +## Description + -If you're fixing a JavaScript issue, it would help to create a new test case under the folder `test/visual/` that recreates the issue and show's that it's been fixed. Run `npm test` to compile the testing folder. + + + + +- Closes -Happy coding! :) +## Motivation and Context + + +## Screenshots (if appropriate): + +## Types of changes + +- [ ] Documentation +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +## Checklist (all required): + + +- [ ] I have read the [CONTRIBUTING](CONTRIBUTING.md) document. +- [ ] There is no other pull request similar to this one. +- [ ] The pull request title is descriptive. +- [ ] The template is fully and correctly filled. +- [ ] The pull request target the right branch (`develop` or `support/*`). +- [ ] My code follows the code style of this project. +- [ ] I have updated the documentation accordingly to my changes (if relevant). +- [ ] I have added tests to cover my changes (if relevant). +- [ ] All new and existing tests passed. + + + -- 2.47.2