From 37c7df4f40c8ab0f13e124c59dbe2e28402c43dc Mon Sep 17 00:00:00 2001
From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Thu, 4 Apr 2024 13:46:05 +0200
Subject: [PATCH] Meson: Rework libdecaf header file detection

---
 meson/libdecaf/meson.build | 47 ++++++++++++--------------------------
 1 file changed, 15 insertions(+), 32 deletions(-)

diff --git a/meson/libdecaf/meson.build b/meson/libdecaf/meson.build
index ae26fc19b6..c7b274bfc3 100644
--- a/meson/libdecaf/meson.build
+++ b/meson/libdecaf/meson.build
@@ -1,9 +1,6 @@
 opt_libdecaf = get_option('signers-libdecaf')
 dep_libdecaf = dependency('', required: false)
 
-found_header = false
-header_path = false
-
 if not opt_libdecaf.disabled()
   dep_libdecaf = dependency('libdecaf', required: false)
 
@@ -21,42 +18,28 @@ if not opt_libdecaf.disabled()
   endif
 
   if dep_libdecaf.found()
-    include_dirs = [
+    message('Libdecaf: Checking for header file')
+
+    include_dirs = include_directories(
       '/usr' / 'include',
       '/usr' / 'include' / 'decaf',
       '/usr' / 'local' / 'include',
       '/usr' / 'local' / 'include' / 'decaf',
-    ]
-
-    do_break = false
-    foreach dirname: include_dirs
-      dir = include_directories(dirname, is_system: true)
-
-      header_path = dirname / 'decaf.hxx'
-      message('Libdecaf: Checking for ' + header_path)
-
-      found_header = cxx.has_header(
-        'decaf.hxx',
-        dependencies: dep_libdecaf,
-        required: false,
-        include_directories: dir,
-      )
+      is_system: true,
+    )
 
-      if found_header
-        dep_libdecaf = declare_dependency(
-          include_directories: dir,
-          dependencies: dep_libdecaf,
-        )
+    cxx.has_header(
+      'decaf.hxx',
+      required: true,
+      include_directories: include_dirs,
+    )
 
-        break
-      endif
-    endforeach
+    dep_libdecaf = declare_dependency(
+      include_directories: dir,
+      dependencies: dep_libdecaf,
+    )
   endif
 endif
 
-conf.set('HAVE_LIBDECAF', dep_libdecaf.found() and found_header, description: 'libdecaf-based signers')
+conf.set('HAVE_LIBDECAF', dep_libdecaf.found(), description: 'libdecaf-based signers')
 summary('libdecaf', dep_libdecaf.found(), bool_yn: true, section: 'Crypto')
-
-if dep_libdecaf.found()
-  summary('libdecaf headers', header_path, bool_yn: true, section: 'Crypto')
-endif
-- 
2.47.2