From 3b1cbbe2448106cc1a07f9897d50b9f77f4e227c Mon Sep 17 00:00:00 2001 From: Jim Jagielski Date: Wed, 6 May 2009 13:56:20 +0000 Subject: [PATCH] At least for right now, mod_heartbeat is not proposed for 2.2.x git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/httpd-2.2-proxy@772266 13f79535-47bb-0310-9956-ffa450edef68 --- modules/proxy/balancers/config2.m4 | 1 - .../proxy/balancers/mod_lbmethod_heartbeat.c | 382 ------------------ .../balancers/mod_lbmethod_heartbeat.dsp | 123 ------ modules/proxy/balancers/modules.mk | 4 +- 4 files changed, 1 insertion(+), 509 deletions(-) delete mode 100644 modules/proxy/balancers/mod_lbmethod_heartbeat.c delete mode 100644 modules/proxy/balancers/mod_lbmethod_heartbeat.dsp diff --git a/modules/proxy/balancers/config2.m4 b/modules/proxy/balancers/config2.m4 index f7232661a84..496a81d696f 100644 --- a/modules/proxy/balancers/config2.m4 +++ b/modules/proxy/balancers/config2.m4 @@ -3,6 +3,5 @@ APACHE_MODPATH_INIT(proxy/balancers) APACHE_MODULE(lbmethod_byrequests, Apache proxy Load balancing by request counting, , , $proxy_mods_enable) APACHE_MODULE(lbmethod_bytraffic, Apache proxy Load balancing by traffic counting, , , $proxy_mods_enable) APACHE_MODULE(lbmethod_bybusyness, Apache proxy Load balancing by busyness, , , $proxy_mods_enable) -APACHE_MODULE(lbmethod_heartbeat, Apache proxy Load balancing from Heartbeats, , , $proxy_mods_enable) APACHE_MODPATH_FINISH diff --git a/modules/proxy/balancers/mod_lbmethod_heartbeat.c b/modules/proxy/balancers/mod_lbmethod_heartbeat.c deleted file mode 100644 index 914c367bb21..00000000000 --- a/modules/proxy/balancers/mod_lbmethod_heartbeat.c +++ /dev/null @@ -1,382 +0,0 @@ -/* Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#include "mod_proxy.h" -#include "scoreboard.h" -#include "ap_mpm.h" -#include "apr_version.h" -#include "apr_hooks.h" - -#ifndef LBM_HEARTBEAT_MAX_LASTSEEN -/* If we haven't seen a heartbeat in the last N seconds, don't count this IP - * as allive. - */ -#define LBM_HEARTBEAT_MAX_LASTSEEN (10) -#endif - -module AP_MODULE_DECLARE_DATA lbmethod_heartbeat_module; - -typedef struct lb_hb_ctx_t -{ - const char *path; -} lb_hb_ctx_t; - -typedef struct hb_server_t { - const char *ip; - int busy; - int ready; - int seen; - proxy_worker *worker; -} hb_server_t; - -static void -argstr_to_table(apr_pool_t *p, char *str, apr_table_t *parms) -{ - char *key; - char *value; - char *strtok_state; - - key = apr_strtok(str, "&", &strtok_state); - while (key) { - value = strchr(key, '='); - if (value) { - *value = '\0'; /* Split the string in two */ - value++; /* Skip passed the = */ - } - else { - value = "1"; - } - ap_unescape_url(key); - ap_unescape_url(value); - apr_table_set(parms, key, value); - /* - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Found query arg: %s = %s", key, value); - */ - key = apr_strtok(NULL, "&", &strtok_state); - } -} - -static apr_status_t read_heartbeats(const char *path, apr_hash_t *servers, - apr_pool_t *pool) -{ - apr_finfo_t fi; - apr_status_t rv; - apr_file_t *fp; - - if (!path) { - return APR_SUCCESS; - } - - rv = apr_file_open(&fp, path, APR_READ|APR_BINARY|APR_BUFFERED, - APR_OS_DEFAULT, pool); - - if (rv) { - return rv; - } - - rv = apr_file_info_get(&fi, APR_FINFO_SIZE, fp); - - if (rv) { - return rv; - } - - { - char *t; - int lineno = 0; - apr_bucket_alloc_t *ba = apr_bucket_alloc_create(pool); - apr_bucket_brigade *bb = apr_brigade_create(pool, ba); - apr_bucket_brigade *tmpbb = apr_brigade_create(pool, ba); - apr_table_t *hbt = apr_table_make(pool, 10); - - apr_brigade_insert_file(bb, fp, 0, fi.size, pool); - - do { - hb_server_t *server; - char buf[4096]; - apr_size_t bsize = sizeof(buf); - const char *ip; - - apr_brigade_cleanup(tmpbb); - - if (APR_BRIGADE_EMPTY(bb)) { - break; - } - - rv = apr_brigade_split_line(tmpbb, bb, - APR_BLOCK_READ, sizeof(buf)); - lineno++; - - if (rv) { - return rv; - } - - apr_brigade_flatten(tmpbb, buf, &bsize); - - if (bsize == 0) { - break; - } - - buf[bsize - 1] = 0; - - /* comment */ - if (buf[0] == '#') { - continue; - } - - /* line format: \n */ - t = strchr(buf, ' '); - if (!t) { - continue; - } - - ip = apr_pstrndup(pool, buf, t - buf); - t++; - - server = apr_hash_get(servers, ip, APR_HASH_KEY_STRING); - - if (server == NULL) { - server = apr_pcalloc(pool, sizeof(hb_server_t)); - server->ip = ip; - server->seen = -1; - - apr_hash_set(servers, server->ip, APR_HASH_KEY_STRING, server); - } - - apr_table_clear(hbt); - - argstr_to_table(pool, apr_pstrdup(pool, t), hbt); - - if (apr_table_get(hbt, "busy")) { - server->busy = atoi(apr_table_get(hbt, "busy")); - } - - if (apr_table_get(hbt, "ready")) { - server->ready = atoi(apr_table_get(hbt, "ready")); - } - - if (apr_table_get(hbt, "lastseen")) { - server->seen = atoi(apr_table_get(hbt, "lastseen")); - } - - if (server->busy == 0 && server->ready != 0) { - /* Server has zero threads active, but lots of them ready, - * it likely just started up, so lets /4 the number ready, - * to prevent us from completely flooding it with all new - * requests. - */ - server->ready = server->ready / 4; - } - - } while (1); - } - - return APR_SUCCESS; -} - -/* - * Finding a random number in a range. - * n' = a + n(b-a+1)/(M+1) - * where: - * n' = random number in range - * a = low end of range - * b = high end of range - * n = random number of 0..M - * M = maxint - * Algorithm 'borrowed' from PHP's rand() function. - */ -#define RAND_RANGE(__n, __min, __max, __tmax) \ -(__n) = (__min) + (long) ((double) ((__max) - (__min) + 1.0) * ((__n) / ((__tmax) + 1.0))) - -static apr_status_t random_pick(apr_uint32_t *number, - apr_uint32_t min, - apr_uint32_t max) -{ - apr_status_t rv = - apr_generate_random_bytes((void*)number, sizeof(apr_uint32_t)); - - if (rv) { - return rv; - } - - RAND_RANGE(*number, min, max, APR_UINT32_MAX); - - return APR_SUCCESS; -} - -static proxy_worker *find_best_hb(proxy_balancer *balancer, - request_rec *r) -{ - apr_status_t rv; - int i; - apr_uint32_t openslots = 0; - proxy_worker **worker; - hb_server_t *server; - apr_array_header_t *up_servers; - proxy_worker *mycandidate = NULL; - apr_pool_t *tpool; - apr_hash_t *servers; - - lb_hb_ctx_t *ctx = - ap_get_module_config(r->server->module_config, - &lbmethod_heartbeat_module); - - apr_pool_create(&tpool, r->pool); - - servers = apr_hash_make(tpool); - - rv = read_heartbeats(ctx->path, servers, tpool); - - if (rv) { - ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, - "lb_heartbeat: Unable to read heartbeats at '%s'", - ctx->path); - apr_pool_destroy(tpool); - return NULL; - } - - up_servers = apr_array_make(tpool, apr_hash_count(servers), sizeof(hb_server_t *)); - - for (i = 0; i < balancer->workers->nelts; i++) { - worker = &APR_ARRAY_IDX(balancer->workers, i, proxy_worker *); - server = apr_hash_get(servers, (*worker)->hostname, APR_HASH_KEY_STRING); - - if (!server) { - continue; - } - - if (!PROXY_WORKER_IS_USABLE(*worker)) { - ap_proxy_retry_worker("BALANCER", *worker, r->server); - } - - if (PROXY_WORKER_IS_USABLE(*worker)) { - server->worker = *worker; - if (server->seen < LBM_HEARTBEAT_MAX_LASTSEEN) { - openslots += server->ready; - APR_ARRAY_PUSH(up_servers, hb_server_t *) = server; - } - } - } - - if (openslots > 0) { - apr_uint32_t c = 0; - apr_uint32_t pick = 0;; - - rv = random_pick(&pick, 0, openslots); - - if (rv) { - ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, - "lb_heartbeat: failed picking a random number. how random."); - apr_pool_destroy(tpool); - return NULL; - } - - for (i = 0; i < up_servers->nelts; i++) { - server = APR_ARRAY_IDX(up_servers, i, hb_server_t *); - if (pick > c && pick <= c + server->ready) { - mycandidate = server->worker; - } - - c += server->ready; - } - } - - apr_pool_destroy(tpool); - - return mycandidate; -} - -static apr_status_t reset(proxy_balancer *balancer, request_rec *r) { - return APR_SUCCESS; -} - -static apr_status_t age(proxy_balancer *balancer, request_rec *r) { - return APR_SUCCESS; -} - -static const proxy_balancer_method heartbeat = -{ - "heartbeat", - &find_best_hb, - &reset, - &age, - NULL -}; - -static void register_hooks(apr_pool_t *p) -{ - ap_register_provider(p, PROXY_LBMETHOD, "heartbeat", "0", &heartbeat); -} - -static void *lb_hb_create_config(apr_pool_t *p, server_rec *s) -{ - lb_hb_ctx_t *ctx = (lb_hb_ctx_t *) apr_palloc(p, sizeof(lb_hb_ctx_t)); - - ctx->path = ap_server_root_relative(p, "logs/hb.dat"); - - return ctx; -} - -static void *lb_hb_merge_config(apr_pool_t *p, void *basev, void *overridesv) -{ - lb_hb_ctx_t *ps = apr_pcalloc(p, sizeof(lb_hb_ctx_t)); - lb_hb_ctx_t *base = (lb_hb_ctx_t *) basev; - lb_hb_ctx_t *overrides = (lb_hb_ctx_t *) overridesv; - - if (overrides->path) { - ps->path = apr_pstrdup(p, overrides->path); - } - else { - ps->path = apr_pstrdup(p, base->path); - } - - return ps; -} - -static const char *cmd_lb_hb_storage(cmd_parms *cmd, - void *dconf, const char *path) -{ - apr_pool_t *p = cmd->pool; - lb_hb_ctx_t *ctx = - (lb_hb_ctx_t *) ap_get_module_config(cmd->server->module_config, - &lbmethod_heartbeat_module); - - const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY); - - if (err != NULL) { - return err; - } - - ctx->path = ap_server_root_relative(p, path); - - return NULL; -} - -static const command_rec cmds[] = { - AP_INIT_TAKE1("HeartbeatStorage", cmd_lb_hb_storage, NULL, RSRC_CONF, - "Path to read heartbeat data."), - {NULL} -}; - -module AP_MODULE_DECLARE_DATA lbmethod_heartbeat_module = { - STANDARD20_MODULE_STUFF, - NULL, /* create per-directory config structure */ - NULL, /* merge per-directory config structures */ - lb_hb_create_config, /* create per-server config structure */ - lb_hb_merge_config, /* merge per-server config structures */ - cmds, /* command apr_table_t */ - register_hooks /* register hooks */ -}; diff --git a/modules/proxy/balancers/mod_lbmethod_heartbeat.dsp b/modules/proxy/balancers/mod_lbmethod_heartbeat.dsp deleted file mode 100644 index fbafed74d11..00000000000 --- a/modules/proxy/balancers/mod_lbmethod_heartbeat.dsp +++ /dev/null @@ -1,123 +0,0 @@ -# Microsoft Developer Studio Project File - Name="mod_lbmethod_heartbeat" - Package Owner=<4> -# Microsoft Developer Studio Generated Build File, Format Version 6.00 -# ** DO NOT EDIT ** - -# TARGTYPE "Win32 (x86) Dynamic-Link Library" 0x0102 - -CFG=mod_lbmethod_heartbeat - Win32 Release -!MESSAGE This is not a valid makefile. To build this project using NMAKE, -!MESSAGE use the Export Makefile command and run -!MESSAGE -!MESSAGE NMAKE /f "mod_lbmethod_heartbeat.mak". -!MESSAGE -!MESSAGE You can specify a configuration when running NMAKE -!MESSAGE by defining the macro CFG on the command line. For example: -!MESSAGE -!MESSAGE NMAKE /f "mod_lbmethod_heartbeat.mak" CFG="mod_lbmethod_heartbeat - Win32 Release" -!MESSAGE -!MESSAGE Possible choices for configuration are: -!MESSAGE -!MESSAGE "mod_lbmethod_heartbeat - Win32 Release" (based on "Win32 (x86) Dynamic-Link Library") -!MESSAGE "mod_lbmethod_heartbeat - Win32 Debug" (based on "Win32 (x86) Dynamic-Link Library") -!MESSAGE - -# Begin Project -# PROP AllowPerConfigDependencies 0 -# PROP Scc_ProjName "" -# PROP Scc_LocalPath "" -CPP=cl.exe -MTL=midl.exe -RSC=rc.exe - -!IF "$(CFG)" == "mod_lbmethod_heartbeat - Win32 Release" - -# PROP BASE Use_MFC 0 -# PROP BASE Use_Debug_Libraries 0 -# PROP BASE Output_Dir "Release" -# PROP BASE Intermediate_Dir "Release" -# PROP BASE Target_Dir "" -# PROP Use_MFC 0 -# PROP Use_Debug_Libraries 0 -# PROP Output_Dir "Release" -# PROP Intermediate_Dir "Release" -# PROP Ignore_Export_Lib 0 -# PROP Target_Dir "" -# ADD BASE CPP /nologo /MD /W3 /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /FD /c -# ADD CPP /nologo /MD /W3 /O2 /Oy- /Zi /I ".." /I "../../../include" /I "../../../srclib/apr/include" /I "../../../srclib/apr-util/include" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /Fd"Release\mod_lbmethod_heartbeat_src" /FD /c -# ADD BASE MTL /nologo /D "NDEBUG" /win32 -# ADD MTL /nologo /D "NDEBUG" /mktyplib203 /win32 -# ADD BASE RSC /l 0x809 /d "NDEBUG" -# ADD RSC /l 0x409 /fo"Release/mod_lbmethod_heartbeat.res" /i "../../../include" /i "../../../srclib/apr/include" /d "NDEBUG" /d BIN_NAME="mod_lbmethod_heartbeat.so" /d LONG_NAME="lbmethod_heartbeat_module for Apache" -BSC32=bscmake.exe -# ADD BASE BSC32 /nologo -# ADD BSC32 /nologo -LINK32=link.exe -# ADD BASE LINK32 kernel32.lib ws2_32.lib mswsock.lib /nologo /subsystem:windows /dll /out:".\Release\mod_lbmethod_heartbeat.so" /base:@..\..\..\os\win32\BaseAddr.ref,mod_lbmethod_heartbeat.so -# ADD LINK32 kernel32.lib ws2_32.lib mswsock.lib /nologo /subsystem:windows /dll /incremental:no /debug /out:".\Release\mod_lbmethod_heartbeat.so" /base:@..\..\..\os\win32\BaseAddr.ref,mod_lbmethod_heartbeat.so /opt:ref -# Begin Special Build Tool -TargetPath=.\Release\mod_lbmethod_heartbeat.so -SOURCE="$(InputPath)" -PostBuild_Desc=Embed .manifest -PostBuild_Cmds=if exist $(TargetPath).manifest mt.exe -manifest $(TargetPath).manifest -outputresource:$(TargetPath);2 -# End Special Build Tool - -!ELSEIF "$(CFG)" == "mod_lbmethod_heartbeat - Win32 Debug" - -# PROP BASE Use_MFC 0 -# PROP BASE Use_Debug_Libraries 1 -# PROP BASE Output_Dir "Debug" -# PROP BASE Intermediate_Dir "Debug" -# PROP BASE Target_Dir "" -# PROP Use_MFC 0 -# PROP Use_Debug_Libraries 1 -# PROP Output_Dir "Debug" -# PROP Intermediate_Dir "Debug" -# PROP Ignore_Export_Lib 0 -# PROP Target_Dir "" -# ADD BASE CPP /nologo /MDd /W3 /EHsc /Zi /Od /D "WIN32" /D "_DEBUG" /D "_WINDOWS" /FD /c -# ADD CPP /nologo /MDd /W3 /EHsc /Zi /Od /I ".." /I "../../../include" /I "../../../srclib/apr/include" /I "../../../srclib/apr-util/include" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /Fd"Debug\mod_lbmethod_heartbeat_src" /FD /c -# ADD BASE MTL /nologo /D "_DEBUG" /win32 -# ADD MTL /nologo /D "_DEBUG" /mktyplib203 /win32 -# ADD BASE RSC /l 0x809 /d "_DEBUG" -# ADD RSC /l 0x409 /fo"Debug/mod_lbmethod_heartbeat.res" /i "../../../include" /i "../../../srclib/apr/include" /d "_DEBUG" /d BIN_NAME="mod_lbmethod_heartbeat.so" /d LONG_NAME="lbmethod_heartbeat_module for Apache" -BSC32=bscmake.exe -# ADD BASE BSC32 /nologo -# ADD BSC32 /nologo -LINK32=link.exe -# ADD BASE LINK32 kernel32.lib ws2_32.lib mswsock.lib /nologo /subsystem:windows /dll /incremental:no /debug /out:".\Debug\mod_lbmethod_heartbeat.so" /base:@..\..\..\os\win32\BaseAddr.ref,mod_lbmethod_heartbeat.so -# ADD LINK32 kernel32.lib ws2_32.lib mswsock.lib /nologo /subsystem:windows /dll /incremental:no /debug /out:".\Debug\mod_lbmethod_heartbeat.so" /base:@..\..\..\os\win32\BaseAddr.ref,mod_lbmethod_heartbeat.so -# Begin Special Build Tool -TargetPath=.\Debug\mod_lbmethod_heartbeat.so -SOURCE="$(InputPath)" -PostBuild_Desc=Embed .manifest -PostBuild_Cmds=if exist $(TargetPath).manifest mt.exe -manifest $(TargetPath).manifest -outputresource:$(TargetPath);2 -# End Special Build Tool - -!ENDIF - -# Begin Target - -# Name "mod_lbmethod_heartbeat - Win32 Release" -# Name "mod_lbmethod_heartbeat - Win32 Debug" -# Begin Group "Source Files" - -# PROP Default_Filter "cpp;c;cxx;rc;def;r;odl;hpj;bat;for;f90" -# Begin Source File - -SOURCE=.\mod_lbmethod_heartbeat.c -# End Source File -# End Group -# Begin Group "Header Files" - -# PROP Default_Filter ".h" -# Begin Source File - -SOURCE=..\mod_proxy.h -# End Source File -# End Group -# Begin Source File - -SOURCE=..\..\..\build\win32\httpd.rc -# End Source File -# End Target -# End Project diff --git a/modules/proxy/balancers/modules.mk b/modules/proxy/balancers/modules.mk index bad51c14bf2..f02d8174563 100644 --- a/modules/proxy/balancers/modules.mk +++ b/modules/proxy/balancers/modules.mk @@ -4,8 +4,6 @@ libmod_lbmethod_bytraffic.la: mod_lbmethod_bytraffic.lo $(MOD_LINK) mod_lbmethod_bytraffic.lo $(MOD_LBMETHOD_BYTRAFFIC_LDADD) libmod_lbmethod_bybusyness.la: mod_lbmethod_bybusyness.lo $(MOD_LINK) mod_lbmethod_bybusyness.lo $(MOD_LBMETHOD_BYBUSYNESS_LDADD) -libmod_lbmethod_heartbeat.la: mod_lbmethod_heartbeat.lo - $(MOD_LINK) mod_lbmethod_heartbeat.lo $(MOD_LBMETHOD_HEARTBEAT_LDADD) DISTCLEAN_TARGETS = modules.mk -static = libmod_lbmethod_byrequests.la libmod_lbmethod_bytraffic.la libmod_lbmethod_bybusyness.la libmod_lbmethod_heartbeat.la +static = libmod_lbmethod_byrequests.la libmod_lbmethod_bytraffic.la libmod_lbmethod_bybusyness.la shared = -- 2.47.2