From 3b1df1f2f24b1f93a501a16f78c2b73f7981056c Mon Sep 17 00:00:00 2001
From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 8 Jul 2017 22:04:48 +1200
Subject: [PATCH] Validate mime icon URL before allocating store entries

---
 src/mime.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mime.cc b/src/mime.cc
index ef610e66df..a159dea369 100644
--- a/src/mime.cc
+++ b/src/mime.cc
@@ -399,6 +399,10 @@ MimeIcon::created(StoreEntry *newEntry)
         status = Http::scNoContent;
     }
 
+    HttpRequest *r = HttpRequest::CreateFromUrl(url_);
+    if (!r)
+        fatalf("mimeLoadIcon: cannot parse internal URL: %s", url_);
+
     // fill newEntry with a canned 2xx response object
     RequestFlags flags;
     flags.cachable = true;
@@ -407,10 +411,6 @@ MimeIcon::created(StoreEntry *newEntry)
     EBIT_SET(e->flags, ENTRY_SPECIAL);
     e->setPublicKey();
     e->buffer();
-    HttpRequest *r = HttpRequest::CreateFromUrl(url_);
-
-    if (NULL == r)
-        fatalf("mimeLoadIcon: cannot parse internal URL: %s", url_);
 
     e->mem_obj->request = r;
     HTTPMSGLOCK(e->mem_obj->request);
-- 
2.47.2