From 3c3cd61e75edf4e324c1d342842cab88dd7330cc Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Fri, 18 Jan 2019 17:31:32 +0100 Subject: [PATCH] test-tables: make the assert more readable Doing it all in one line and with negation in front seemed like a good idea at some point, but I think it is vastly easier to understand when it is split out a bit. --- src/shared/test-tables.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/shared/test-tables.h b/src/shared/test-tables.h index 120dc7f2e9f..e68ec604974 100644 --- a/src/shared/test-tables.h +++ b/src/shared/test-tables.h @@ -31,9 +31,13 @@ static inline void _test_table(const char *name, else if (boring == 1) printf("%*s ...\n", (int) strlen(name), ""); - assert_se(!(i >= 0 && i < size ? - sparse ? rev != i && rev != -1 : val == NULL || rev != i : - val != NULL || rev != -1)); + if (i >= 0 && i < size) { + if (sparse) + assert_se(rev == i || rev == -1); + else + assert_se(val != NULL && rev == i); + } else + assert_se(val == NULL && rev == -1); } } -- 2.47.3