From 3c9512c71d49d42513755cfa4329275c0360f397 Mon Sep 17 00:00:00 2001 From: Jouke Witteveen Date: Sat, 26 Nov 2016 10:16:47 +0100 Subject: [PATCH] service: prevent registering control pids as the main pid We assume a process can be only one of the two in service_sigchld_event. --- src/core/service.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/service.c b/src/core/service.c index 39b3589e6ba..bb67bdf84ca 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -3071,6 +3071,8 @@ static void service_notify_message(Unit *u, pid_t pid, char **tags, FDSet *fds) if (e && IN_SET(s->state, SERVICE_START, SERVICE_START_POST, SERVICE_RUNNING, SERVICE_RELOAD)) { if (parse_pid(e, &pid) < 0) log_unit_warning(u, "Failed to parse MAINPID= field in notification message: %s", e); + else if (pid == s->control_pid) + log_unit_warning(u, "A control process cannot also be the main process"); else { service_set_main_pid(s, pid); unit_watch_pid(UNIT(s), pid); -- 2.47.3