From 3c9ed9f4bce54c2f86fb1c8cc251b25bf47df751 Mon Sep 17 00:00:00 2001 From: Jason Kirtland Date: Sat, 16 Jun 2007 15:51:13 +0000 Subject: [PATCH] - Put a mutex around the QueuePool's overflow handlings --- lib/sqlalchemy/pool.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/sqlalchemy/pool.py b/lib/sqlalchemy/pool.py index a77e979abd..075e5cbc4e 100644 --- a/lib/sqlalchemy/pool.py +++ b/lib/sqlalchemy/pool.py @@ -23,9 +23,11 @@ from sqlalchemy import exceptions, logging from sqlalchemy import queue as Queue try: - import thread + import dummy_threading + import thread, threading except: import dummy_thread as thread + import dummy_threading as threading proxies = {} @@ -469,6 +471,7 @@ class QueuePool(Pool): self._overflow = 0 - pool_size self._max_overflow = max_overflow self._timeout = timeout + self._overflow_lock = max_overflow > 0 and threading.Lock() or dummy_threading.Lock() def recreate(self): self.log("Pool recreating") @@ -478,16 +481,22 @@ class QueuePool(Pool): try: self._pool.put(conn, False) except Queue.Full: + self._overflow_lock.acquire() self._overflow -= 1 + self._overflow_lock.release() def do_get(self): try: return self._pool.get(self._max_overflow > -1 and self._overflow >= self._max_overflow, self._timeout) except Queue.Empty: - if self._max_overflow > -1 and self._overflow >= self._max_overflow: - raise exceptions.TimeoutError("QueuePool limit of size %d overflow %d reached, connection timed out" % (self.size(), self.overflow())) - con = self.create_connection() - self._overflow += 1 + self._overflow_lock.acquire() + try: + if self._max_overflow > -1 and self._overflow >= self._max_overflow: + raise exceptions.TimeoutError("QueuePool limit of size %d overflow %d reached, connection timed out" % (self.size(), self.overflow())) + con = self.create_connection() + self._overflow += 1 + finally: + self._overflow_lock.release() return con def dispose(self): -- 2.47.3