From 3dae81c8d718ccd6a75f0e76380186ed0877d786 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 2 Apr 2025 17:45:23 +0200 Subject: [PATCH] ch: Use CH_DOMAIN_PRIVATE() more MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There are two instances where vm->privateData is typecasted only so that it can be dereferenced further. Well, that's exactly what CH_DOMAIN_PRIVATE() macro is for. Use that instead. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/ch/ch_events.c | 2 +- src/ch/ch_process.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_events.c b/src/ch/ch_events.c index f1dc5c6f4c..9cb873d8cd 100644 --- a/src/ch/ch_events.c +++ b/src/ch/ch_events.c @@ -54,7 +54,7 @@ static int virCHEventStopProcess(virDomainObj *vm, virDomainShutoffReason reason) { - virCHDriver *driver = ((virCHDomainObjPrivate *)vm->privateData)->driver; + virCHDriver *driver = CH_DOMAIN_PRIVATE(vm)->driver; virObjectLock(vm); if (virDomainObjBeginJob(vm, VIR_JOB_DESTROY)) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index e8d482da97..6a59bf756a 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -430,8 +430,8 @@ virCHProcessSetupVcpus(virDomainObj *vm) size_t i; if ((vm->def->cputune.period || vm->def->cputune.quota) && - !virCgroupHasController(((virCHDomainObjPrivate *) vm->privateData)-> - cgroup, VIR_CGROUP_CONTROLLER_CPU)) { + !virCgroupHasController(CH_DOMAIN_PRIVATE(vm)->cgroup, + VIR_CGROUP_CONTROLLER_CPU)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("cgroup cpu is required for scheduler tuning")); return -1; -- 2.47.3