From 3df94e62f478e43ce95923c1c48ba0fef8909142 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 12 May 2017 12:07:31 +0200 Subject: [PATCH] s4:ldap_server: remove pointless (result != LDAP_SUCCESS) check We set result = LDAP_SUCCESS above and have goto do_reply; in all cases where we overwrite 'result'. Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- source4/ldap_server/ldap_bind.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c index 6a88891152f..7f14384f359 100644 --- a/source4/ldap_server/ldap_bind.c +++ b/source4/ldap_server/ldap_bind.c @@ -505,8 +505,7 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call) } } - if (result != LDAP_SUCCESS) { - } else if (!NT_STATUS_IS_OK(status)) { + if (!NT_STATUS_IS_OK(status)) { result = LDAP_OPERATIONS_ERROR; errstr = talloc_asprintf(reply, "SASL:[%s]: Failed to setup SASL socket: %s", -- 2.47.2