From 3e2ed8c03759591bcec60c70697beb39ba87a4ea Mon Sep 17 00:00:00 2001 From: Ben Darnell Date: Tue, 21 Jun 2011 20:43:14 -0700 Subject: [PATCH] Add test for unicode domain and path arguments to set_cookie --- tornado/test/web_test.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tornado/test/web_test.py b/tornado/test/web_test.py index f02d31f2c..ae1955f79 100644 --- a/tornado/test/web_test.py +++ b/tornado/test/web_test.py @@ -65,9 +65,18 @@ class CookieTest(AsyncHTTPTestCase, LogTrapTestCase): def get(self): self.write(self.get_cookie("foo")) + class SetCookieDomainHandler(RequestHandler): + def get(self): + # unicode domain and path arguments shouldn't break things + # either (see bug #285) + self.set_cookie("unicode_args", "blah", domain=u"foo.com", + path=u"/foo") + + return Application([ ("/set", SetCookieHandler), - ("/get", GetCookieHandler)]) + ("/get", GetCookieHandler), + ("/set_domain", SetCookieDomainHandler)]) def test_set_cookie(self): response = self.fetch("/set") @@ -80,6 +89,11 @@ class CookieTest(AsyncHTTPTestCase, LogTrapTestCase): response = self.fetch("/get", headers={"Cookie": "foo=bar"}) self.assertEqual(response.body, b("bar")) + def test_set_cookie_domain(self): + response = self.fetch("/set_domain") + self.assertEqual(response.headers.get_list("Set-Cookie"), + ["unicode_args=blah; Domain=foo.com; Path=/foo"]) + class AuthRedirectRequestHandler(RequestHandler): def initialize(self, login_url): self.login_url = login_url -- 2.47.2