From 3e88a26e4c934935cd5e9c0c1b7b9c6a7e195516 Mon Sep 17 00:00:00 2001 From: Rico Tzschichholz Date: Tue, 27 Apr 2021 10:24:55 +0200 Subject: [PATCH] codegen: Don't use G_GNUC_INTERNAL on implicit type specific fields The actual field was never handled that way, so don't apply it at all when --hide-internal is passed. Introduced by 970f58989a2863faca11e30fdbcf4da1273a6acd which claimed to apply it to methods only. Fixes https://gitlab.gnome.org/GNOME/vala/issues/1178 --- codegen/valaccodebasemodule.vala | 8 -------- 1 file changed, 8 deletions(-) diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala index c00ddc7be..f47bed274 100644 --- a/codegen/valaccodebasemodule.vala +++ b/codegen/valaccodebasemodule.vala @@ -1113,8 +1113,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator { if (f.is_private_symbol ()) { flock.modifiers = CCodeModifiers.STATIC; - } else if (context.hide_internal && f.is_internal_symbol ()) { - flock.modifiers = CCodeModifiers.INTERNAL; } else { flock.modifiers = CCodeModifiers.EXTERN; } @@ -1132,8 +1130,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator { cdecl.add_declarator (new CCodeVariableDeclarator (get_variable_array_length_cname (f, dim))); if (f.is_private_symbol ()) { cdecl.modifiers = CCodeModifiers.STATIC; - } else if (context.hide_internal && f.is_internal_symbol ()) { - cdecl.modifiers = CCodeModifiers.INTERNAL; } else { cdecl.modifiers = CCodeModifiers.EXTERN; } @@ -1149,8 +1145,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator { cdecl.add_declarator (new CCodeVariableDeclarator (get_ccode_delegate_target_name (f))); if (f.is_private_symbol ()) { cdecl.modifiers = CCodeModifiers.STATIC; - } else if (context.hide_internal && f.is_internal_symbol ()) { - cdecl.modifiers = CCodeModifiers.INTERNAL; } else { cdecl.modifiers = CCodeModifiers.EXTERN; } @@ -1161,8 +1155,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator { cdecl.add_declarator (new CCodeVariableDeclarator (get_ccode_delegate_target_destroy_notify_name (f))); if (f.is_private_symbol ()) { cdecl.modifiers = CCodeModifiers.STATIC; - } else if (context.hide_internal && f.is_internal_symbol ()) { - cdecl.modifiers = CCodeModifiers.INTERNAL; } else { cdecl.modifiers = CCodeModifiers.EXTERN; } -- 2.47.2