From 3e899ef5bfa67a12e8eb18cbebc06367f37a8376 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 18 Apr 2024 01:49:11 +1200 Subject: [PATCH] ldb-samba: remove unused ldif_comparision_objectSid_isString() This is unused because it does things badly, by just guessing and not allowing valid sids that start with "s-". All the places that used to use it were calling ldif_read_objectSid() or similar which correctly check for string SIDs by actually trying to parse them. That begins with looking for the "S-"/"s-", so this shortcut is not saving any real work. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10763 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- lib/ldb-samba/ldif_handlers.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c index 5b9737542e9..b803c4486d3 100644 --- a/lib/ldb-samba/ldif_handlers.c +++ b/lib/ldb-samba/ldif_handlers.c @@ -138,17 +138,6 @@ int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx, return 0; } -bool ldif_comparision_objectSid_isString(const struct ldb_val *v) -{ - if (v->length < 3) { - return false; - } - - if (strncmp("S-", (const char *)v->data, 2) != 0) return false; - - return true; -} - /* compare two objectSids -- 2.47.3