From 3f617061eceb2f33fb40682cc7b14cc4f9a2143f Mon Sep 17 00:00:00 2001 From: Pauli Date: Mon, 7 Jun 2021 09:45:40 +1000 Subject: [PATCH] evp: fix Coverity 1485669 improper use of negative value Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/15635) --- crypto/evp/ctrl_params_translate.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crypto/evp/ctrl_params_translate.c b/crypto/evp/ctrl_params_translate.c index e289c7df7b2..6998dcc6fc1 100644 --- a/crypto/evp/ctrl_params_translate.c +++ b/crypto/evp/ctrl_params_translate.c @@ -1704,6 +1704,10 @@ static int get_ec_decoded_from_explicit_params(enum state state, #ifndef OPENSSL_NO_EC case EVP_PKEY_EC: val = EC_KEY_decoded_from_explicit_params(EVP_PKEY_get0_EC_KEY(pkey)); + if (val < 0) { + ERR_raise(ERR_LIB_EVP, EVP_R_INVALID_KEY); + return 0; + } break; #endif default: -- 2.47.2