From 412f0d1b708f6611e47d74b7eb09c3ecf7390dd5 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Wed, 20 Mar 2024 16:01:00 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Fred Morcos --- pdns/recursordist/rec-main.cc | 4 ++-- pdns/recursordist/settings/table.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc index 7b334f0101..d7f98298bf 100644 --- a/pdns/recursordist/rec-main.cc +++ b/pdns/recursordist/rec-main.cc @@ -3040,13 +3040,13 @@ static void setupLogging(const string& logname) } #endif if (g_slog == nullptr) { - cerr << "Structured logging to systemd-journal requested but it is not available" << endl; + cerr << "Requested structured logging to systemd-journal, but it is not available" << endl; } } else if (logname == "json") { g_slog = Logging::Logger::create(loggerJSONBackend); if (g_slog == nullptr) { - cerr << "JSON logging to requested but it is not available" << endl; + cerr << "JSON logging requested but it is not available" << endl; } } diff --git a/pdns/recursordist/settings/table.py b/pdns/recursordist/settings/table.py index 8f92f630ad..145248439f 100644 --- a/pdns/recursordist/settings/table.py +++ b/pdns/recursordist/settings/table.py @@ -2670,7 +2670,7 @@ Available backends are: - ``default``: use the traditional logging system to output structured logging information. - ``systemd-journal``: use systemd-journal. When using this backend, provide ``-o verbose`` or simular output option to ``journalctl`` to view the full information. -- ``json``: JSON objects are written to the standard error stream +- ``json``: JSON objects are written to the standard error stream. See :doc:`appendices/structuredlogging` for more details. ''', -- 2.47.2