From 4140dbedd9d2733b2beb1fda0878ad742f1122d2 Mon Sep 17 00:00:00 2001 From: Osier Yang Date: Tue, 20 Aug 2013 17:08:49 +0800 Subject: [PATCH] storage: Fix the use-after-free memory bug Introduced by commit e0139e30444. virStorageVolDefFree free'ed the pointers that are still used by the added volume object, this changes it back to VIR_FREE. --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 58d0fc0d41..323be9e3bf 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1618,7 +1618,7 @@ storageVolCreateXML(virStoragePoolPtr obj, cleanup: virObjectUnref(volobj); virStorageVolDefFree(voldef); - virStorageVolDefFree(buildvoldef); + VIR_FREE(buildvoldef); if (pool) virStoragePoolObjUnlock(pool); return ret; -- 2.47.2