From 41b5364511776eeb39bf4ad9bf82766aff6d1629 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 25 May 2022 15:01:15 +0200 Subject: [PATCH] detect/parse: cleanup test --- src/detect-parse.c | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/src/detect-parse.c b/src/detect-parse.c index 01070462e2..b1b1e7cb8f 100644 --- a/src/detect-parse.c +++ b/src/detect-parse.c @@ -3907,26 +3907,14 @@ end: */ static int SigParseTestNegation07 (void) { - int result = 0; - DetectEngineCtx *de_ctx; - Signature *s=NULL; - - de_ctx = DetectEngineCtxInit(); - if (de_ctx == NULL) - goto end; + DetectEngineCtx *de_ctx = DetectEngineCtxInit(); + FAIL_IF_NULL(de_ctx); de_ctx->flags |= DE_QUIET; - - s = SigInit(de_ctx,"alert tcp any any -> [192.168.0.2,!192.168.0.0/24] any (msg:\"SigTest41-06 dst ip [192.168.0.2,!192.168.0.0/24] \"; classtype:misc-activity; sid:410006; rev:1;)"); - if (s != NULL) { - SigFree(de_ctx, s); - goto end; - } - - result = 1; -end: - if (de_ctx != NULL) - DetectEngineCtxFree(de_ctx); - return result; + Signature *s = DetectEngineAppendSig( + de_ctx, "alert tcp any any -> [192.168.0.2,!192.168.0.0/24] any (sid:410006;)"); + FAIL_IF_NOT_NULL(s); + DetectEngineCtxFree(de_ctx); + PASS; } /** -- 2.47.2