From 426abb6183c8e77bdd24a6317abd4f0e5d7f3325 Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Fri, 30 Sep 2022 08:37:54 -0600 Subject: [PATCH] tools/cgexec: use exit code 129 on invalid usage The exit code 1 refers to general error and using -1 wraps to 255, both codes do not signify bad arguments. Let's use exit code 129 (EXIT_BADARGS) for hinting to the users about invalid usage. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka (cherry picked from commit 13f8ddd305a24a17934f467244f0dc3887f45a48) --- src/tools/cgexec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/cgexec.c b/src/tools/cgexec.c index eb3a91fb..efd499b0 100644 --- a/src/tools/cgexec.c +++ b/src/tools/cgexec.c @@ -70,7 +70,7 @@ int main(int argc, char *argv[]) ret = parse_cgroup_spec(cgroup_list, optarg, CG_HIER_MAX); if (ret) { err("cgroup controller and path parsing failed\n"); - return -1; + exit(EXIT_BADARGS); } cg_specified = 1; break; @@ -82,14 +82,14 @@ int main(int argc, char *argv[]) exit(0); default: usage(1, argv[0]); - exit(1); + exit(EXIT_BADARGS); } } /* Executable name */ if (!argv[optind]) { usage(1, argv[0]); - exit(1); + exit(EXIT_BADARGS); } /* Initialize libcg */ -- 2.47.2