From 433a35bcc7cabbc6198d81d2a7e09621866dc51f Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Tue, 4 Apr 2017 22:38:18 +0100 Subject: [PATCH] compat: Add non-None queryset attribute Older versions of Django REST Framework's 'RelatedField' did not check for the presence 'get_queryset' before checking for a 'queryset' attribute. This was fixed in 3.4.0 [1] and backported to the 3.3 series in 3.3.3 [2]. However, the fix was not backported to the last release of 3.2 series [3], which is the last release to support Django 1.6. As such, we must set a 'queryset' attribute, even if it's set to a garbage value. [1] ../blob/3.4.0/rest_framework/relations.py#L78-L82 [2] ../blob/3.3.3/rest_framework/relations.py#L78-L82 [3] ../blob/3.2.5/rest_framework/relations.py#L64-L67 Signed-off-by: Stephen Finucane Closes-bug: #94 --- patchwork/api/patch.py | 1 + 1 file changed, 1 insertion(+) diff --git a/patchwork/api/patch.py b/patchwork/api/patch.py index ded49101..fa6fb46f 100644 --- a/patchwork/api/patch.py +++ b/patchwork/api/patch.py @@ -53,6 +53,7 @@ class StateField(RelatedField): 'incorrect_type': _('Incorrect type. Expected string value, received ' '{data_type}.'), } + queryset = '' # django 1.6, rest_framework 3.2 require this def to_internal_value(self, data): try: -- 2.47.3