From 43ce3e73114d5c5b4fd766ee0804866cdd2a83ef Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 9 Aug 2020 13:58:10 +0100 Subject: [PATCH] sfdisk: do not free device name too soon [coverity scan] Fixes use after free error. CID: 360798 Signed-off-by: Sami Kerola --- disk-utils/sfdisk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c index 2e8d7ea0e5..4e12f87a5c 100644 --- a/disk-utils/sfdisk.c +++ b/disk-utils/sfdisk.c @@ -621,7 +621,6 @@ done: if (f) fclose(f); free(buf); - free(devname); free(typescript); if (sf->noact) @@ -632,6 +631,8 @@ done: } else if (rc) warn(_("%s: failed to move data"), devname); + free(devname); + return rc; } -- 2.47.3