From 43eae1b7077104d4e2ed52447407a335c2d093e3 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Tue, 18 Feb 2025 11:24:32 +0100 Subject: [PATCH] qemu: Avoid crash in qemuDomainCheckCPU with unknown host CPU When we don't have any information about host CPU (for example when running on an aarch64 host), the virQEMUCapsGetHostModel would return NULL. Fixes: f928eb5fc80ca0ed7277f2513b63aed36c09d275 Fixes: https://gitlab.com/libvirt/libvirt/-/issues/747 Signed-off-by: Jiri Denemark Tested-by: Jaroslav Suchanek Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cf05dca55a..df1ed0223d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11430,6 +11430,7 @@ qemuDomainCheckCPU(virArch arch, /* Force compat check if the CPU model is not found in qemuCaps or * we don't have host CPU data from QEMU */ if (!cpu->model || + !hypervisorCPU || hypervisorCPU->fallback != VIR_CPU_FALLBACK_FORBID || virQEMUCapsGetCPUBlockers(qemuCaps, virtType, cpu->model, &blockers) < 0) -- 2.47.3