From 440ad03aa4faffec9769452e60151b3f70defd15 Mon Sep 17 00:00:00 2001 From: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Date: Sun, 26 Oct 2025 17:52:10 +0000 Subject: [PATCH] address review --- .github/workflows/jit.yml | 4 ++-- Include/internal/pycore_backoff.h | 2 +- Python/bytecodes.c | 2 +- Python/ceval_macros.h | 1 - Tools/cases_generator/tier1_generator.py | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index c91328cf01cc..6d0cd952442d 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -57,7 +57,7 @@ jobs: fail-fast: false matrix: target: -# To re-enable later when we support thesee. +# To re-enable later when we support these. # - i686-pc-windows-msvc/msvc # - x86_64-pc-windows-msvc/msvc # - aarch64-pc-windows-msvc/msvc @@ -71,7 +71,7 @@ jobs: llvm: - 19 include: -# To re-enable later when we support thesee. +# To re-enable later when we support these. # - target: i686-pc-windows-msvc/msvc # architecture: Win32 # runner: windows-2022 diff --git a/Include/internal/pycore_backoff.h b/Include/internal/pycore_backoff.h index 86ae7885fd1c..8ca351c30258 100644 --- a/Include/internal/pycore_backoff.h +++ b/Include/internal/pycore_backoff.h @@ -135,7 +135,7 @@ initial_unreachable_backoff_counter(void) } // Required to not get stuck in infinite specialization loops due to specialization failure. -// We use 2 here as tnere are a few scenarios: +// We use 2 here as there are a few scenarios: // 1. Freshly specialized from unspecialized, in which case the counter will be 1. // 2. Re-specialized from deopt, in which case the counter will be 1. // 3. Deopt -> Specialize -> Deopt -> Specialize, in which case the counter will be 2. diff --git a/Python/bytecodes.c b/Python/bytecodes.c index bcc9f220335c..cd098ebe0eb2 100644 --- a/Python/bytecodes.c +++ b/Python/bytecodes.c @@ -3232,7 +3232,7 @@ dummy_func( ERROR_NO_POP(); } /* iterator ended normally */ - /* This just sets the IP to what it expects (see normal _FOR_ITER */ + /* This just sets the IP to what it expects (see normal _FOR_ITER) */ frame->instr_ptr += (oparg + 2 + INLINE_CACHE_ENTRIES_FOR_ITER); EXIT_IF(true); } diff --git a/Python/ceval_macros.h b/Python/ceval_macros.h index af992cc38ebb..b845544beec6 100644 --- a/Python/ceval_macros.h +++ b/Python/ceval_macros.h @@ -209,7 +209,6 @@ do { \ JUMP_TO_LABEL(start_frame); \ } while (0) - /* Tuple access macros */ #ifndef Py_DEBUG diff --git a/Tools/cases_generator/tier1_generator.py b/Tools/cases_generator/tier1_generator.py index a7961f4fbc7c..fb1874b1658c 100644 --- a/Tools/cases_generator/tier1_generator.py +++ b/Tools/cases_generator/tier1_generator.py @@ -288,7 +288,7 @@ def generate_tier1_cases( out.start_line() if reachable: # type: ignore[possibly-undefined] stack.flush(out) - out.emit(f"DISPATCH();\n") + out.emit("DISPATCH();\n") out.start_line() out.emit("}") out.emit("\n") -- 2.47.3