From 441b6c31e9d8e45ecf09379ff7494743889f36fd Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 14 Sep 2020 08:43:51 +0200 Subject: [PATCH] BUILD: connection: fix build on clang after the VAR_ARRAY cleanup Commit 4987a4744 ("CLEANUP: tree-wide: use VAR_ARRAY instead of [0] in various definitions") broke the build on clang due to the tlv field used to receive/send the proxy protocol. The problem is that struct tlv is included at the beginning of struct tlv_ssl, which doesn't make much sense. In fact the value[] array isn't really a var array but just an end of struct marker, and must really be an array of size zero. --- include/haproxy/connection-t.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/connection-t.h b/include/haproxy/connection-t.h index 3aab5d05ef..9caa2ca499 100644 --- a/include/haproxy/connection-t.h +++ b/include/haproxy/connection-t.h @@ -589,7 +589,7 @@ struct tlv { uint8_t type; uint8_t length_hi; uint8_t length_lo; - uint8_t value[VAR_ARRAY]; + uint8_t value[0]; }__attribute__((packed)); struct tlv_ssl { -- 2.39.5