From 447598449817fcaea26016d9102d703c4d16bd9c Mon Sep 17 00:00:00 2001 From: Andreas Henriksson Date: Fri, 12 Oct 2007 10:56:46 +0200 Subject: [PATCH] Fix overflow in time2tick / tick2time. The helper functions gets passed an unsigned int, which gets cast to long and overflows. See http://bugs.debian.org/175462 Signed-off-by: Andreas Henriksson Signed-off-by: Stephen Hemminger --- tc/tc_core.c | 4 ++-- tc/tc_core.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tc/tc_core.c b/tc/tc_core.c index 58155fbf7..fb8987669 100644 --- a/tc/tc_core.c +++ b/tc/tc_core.c @@ -35,12 +35,12 @@ int tc_core_time2big(long time) } -long tc_core_time2tick(long time) +unsigned tc_core_time2tick(unsigned time) { return time*tick_in_usec; } -long tc_core_tick2time(long tick) +unsigned tc_core_tick2time(unsigned tick) { return tick/tick_in_usec; } diff --git a/tc/tc_core.h b/tc/tc_core.h index a139da6f6..b2a16bc32 100644 --- a/tc/tc_core.h +++ b/tc/tc_core.h @@ -7,8 +7,8 @@ #define TIME_UNITS_PER_SEC 1000000 int tc_core_time2big(long time); -long tc_core_time2tick(long time); -long tc_core_tick2time(long tick); +unsigned tc_core_time2tick(unsigned time); +unsigned tc_core_tick2time(unsigned tick); long tc_core_time2ktime(long time); long tc_core_ktime2time(long ktime); unsigned tc_calc_xmittime(unsigned rate, unsigned size); -- 2.47.2