From 45200770fe6862b609adab3f620ef892bb9c27ff Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 9 Feb 2024 13:05:28 +0100 Subject: [PATCH] smbd: Simplify smbXsrv_open_clear_replay_cache() GUID_buf_string() is designed to never fail Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- source3/smbd/smbXsrv_open.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/source3/smbd/smbXsrv_open.c b/source3/smbd/smbXsrv_open.c index 31cbef29bd5..6fd64a028c9 100644 --- a/source3/smbd/smbXsrv_open.c +++ b/source3/smbd/smbXsrv_open.c @@ -676,7 +676,6 @@ static NTSTATUS smbXsrv_open_clear_replay_cache(struct smbXsrv_open *op) { struct GUID *create_guid; struct GUID_txt_buf buf; - char *guid_string; struct db_context *db; NTSTATUS status; @@ -695,12 +694,7 @@ static NTSTATUS smbXsrv_open_clear_replay_cache(struct smbXsrv_open *op) return NT_STATUS_OK; } - guid_string = GUID_buf_string(create_guid, &buf); - if (guid_string == NULL) { - return NT_STATUS_INVALID_PARAMETER; - } - - status = dbwrap_purge_bystring(db, guid_string); + status = dbwrap_purge_bystring(db, GUID_buf_string(create_guid, &buf)); if (NT_STATUS_IS_OK(status)) { op->flags &= ~SMBXSRV_OPEN_HAVE_REPLAY_CACHE; -- 2.47.3