From 462dd7c2de62bd0f385b049da2a2b54b4c4f7b51 Mon Sep 17 00:00:00 2001 From: Corey Farrell Date: Thu, 5 Oct 2017 21:23:31 -0400 Subject: [PATCH] main/strings: Fix uninitialized value. ast_strings_match uses sscanf and checks for non-zero return to verify a token was parsed. This is incorrect as sscanf returns EOF (-1) for errors. ASTERISK-27318 #close Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1 --- main/strings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/strings.c b/main/strings.c index 38b4c946ff..8102c3e9d0 100644 --- a/main/strings.c +++ b/main/strings.c @@ -314,7 +314,7 @@ regex: } equals: - scan_numeric = (sscanf(left, "%lf", &left_num) && sscanf(internal_right, "%lf", &right_num)); + scan_numeric = (sscanf(left, "%lf", &left_num) > 0 && sscanf(internal_right, "%lf", &right_num) > 0); if (internal_op[0] == '=') { if (ast_strlen_zero(left) && ast_strlen_zero(internal_right)) { -- 2.47.2