From 47cde199cb3e9c88b836a40925be3183fc888947 Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date: Tue, 14 Apr 2020 17:34:02 +1200 Subject: [PATCH] Define connection.close as asynchronous --- psycopg3/connection.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/psycopg3/connection.py b/psycopg3/connection.py index 769afc910..bcf606450 100644 --- a/psycopg3/connection.py +++ b/psycopg3/connection.py @@ -57,9 +57,6 @@ class BaseConnection: # name of the postgres encoding (in bytes) self._pgenc = b"" - def close(self) -> None: - self.pgconn.finish() - @property def closed(self) -> bool: return self.status == self.ConnStatus.BAD @@ -136,6 +133,9 @@ class Connection(BaseConnection): pgconn = cls.wait(gen) return cls(pgconn) + def close(self) -> None: + self.pgconn.finish() + def cursor( self, name: Optional[str] = None, binary: bool = False ) -> cursor.Cursor: @@ -194,12 +194,15 @@ class AsyncConnection(BaseConnection): self.cursor_factory = cursor.AsyncCursor @classmethod - async def connect(cls, conninfo: str, **kwargs: Any) -> "AsyncConnection": + async def connect(cls, conninfo: str = "", **kwargs: Any) -> "AsyncConnection": conninfo = make_conninfo(conninfo, **kwargs) gen = generators.connect(conninfo) pgconn = await cls.wait(gen) return cls(pgconn) + async def close(self) -> None: + self.pgconn.finish() + def cursor( self, name: Optional[str] = None, binary: bool = False ) -> cursor.AsyncCursor: -- 2.47.2