From 47d622b5605cc81b1266bbae8e448644251b9173 Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Tue, 22 Sep 2020 21:33:42 -0400 Subject: [PATCH] conf: eliminate virDomainNetDefClear() This function is no longer used anywhere except virDomainNetDefFree(), so just inline its contents there. Signed-off-by: Laine Stump Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 9 +-------- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f60d495407..7c9fb3494d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2491,7 +2491,7 @@ virDomainVsockDefFree(virDomainVsockDefPtr vsock) void -virDomainNetDefClear(virDomainNetDefPtr def) +virDomainNetDefFree(virDomainNetDefPtr def) { if (!def) return; @@ -2566,14 +2566,7 @@ virDomainNetDefClear(virDomainNetDefPtr def) virNetDevBandwidthFree(def->bandwidth); def->bandwidth = NULL; virNetDevVlanClear(&def->vlan); -} -void -virDomainNetDefFree(virDomainNetDefPtr def) -{ - if (!def) - return; - virDomainNetDefClear(def); virObjectUnref(def->privateData); VIR_FREE(def); } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8f1662aae0..9a44315519 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3056,7 +3056,6 @@ void virDomainActualNetDefFree(virDomainActualNetDefPtr def); virDomainVsockDefPtr virDomainVsockDefNew(virDomainXMLOptionPtr xmlopt); void virDomainVsockDefFree(virDomainVsockDefPtr vsock); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainVsockDef, virDomainVsockDefFree); -void virDomainNetDefClear(virDomainNetDefPtr def); void virDomainNetDefFree(virDomainNetDefPtr def); void virDomainSmartcardDefFree(virDomainSmartcardDefPtr def); void virDomainChrDefFree(virDomainChrDefPtr def); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6bcbfa667d..4e66385bab 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -507,7 +507,6 @@ virDomainNetARPInterfaces; virDomainNetBandwidthUpdate; virDomainNetDefActualFromNetworkPort; virDomainNetDefActualToNetworkPort; -virDomainNetDefClear; virDomainNetDefFormat; virDomainNetDefFree; virDomainNetDefNew; -- 2.47.2