From 491af20b3c6d5baedb96357d4b12232ae490cbe7 Mon Sep 17 00:00:00 2001 From: Caleb Sander Mateos Date: Fri, 30 Jan 2026 08:25:30 -0700 Subject: [PATCH] ublk: remove "can't touch 'ublk_io' any more" comments The struct ublk_io is in fact accessed in __ublk_complete_rq() after the comment. But it's not racy to access the ublk_io between clearing its UBLK_IO_FLAG_OWNED_BY_SRV flag and completing the request, as no other thread can use the ublk_io in the meantime. Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Signed-off-by: Jens Axboe --- drivers/block/ublk_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 4fe754e7d1e8b..3c918db4905c7 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -3349,7 +3349,6 @@ static int ublk_ch_uring_cmd_local(struct io_uring_cmd *cmd, io_buffer_unregister_bvec(cmd, buf_idx, issue_flags); compl = ublk_need_complete_req(ub, io); - /* can't touch 'ublk_io' any more */ if (req_op(req) == REQ_OP_ZONE_APPEND) req->__sector = addr; if (compl) @@ -3681,7 +3680,6 @@ static int ublk_batch_commit_io(struct ublk_queue *ubq, return ret; } - /* can't touch 'ublk_io' any more */ if (buf_idx != UBLK_INVALID_BUF_IDX) io_buffer_unregister_bvec(data->cmd, buf_idx, data->issue_flags); if (req_op(req) == REQ_OP_ZONE_APPEND) -- 2.47.3