From 49d2a42b69b68d8b04dc976ee947f18367695911 Mon Sep 17 00:00:00 2001 From: Tim Wiederhake Date: Fri, 23 Jul 2021 11:42:47 +0200 Subject: [PATCH] virNWFilterParseParamAttributes: Simplify loop MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/conf/nwfilter_params.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 35ea0256c3..ca7b62874c 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -700,9 +700,8 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) { g_autoptr(GHashTable) table = virHashNew(virNWFilterVarValueHashFree); - cur = xmlFirstElementChild(cur); - - while (cur != NULL) { + for (cur = xmlFirstElementChild(cur); cur != NULL; + cur = xmlNextElementSibling(cur)) { if (virXMLNodeNameEqual(cur, "parameter")) { g_autofree char *nam = virXMLPropString(cur, "name"); g_autofree char *val = virXMLPropString(cur, "value"); @@ -710,7 +709,6 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) if (nam == NULL || !isValidVarName(nam) || val == NULL || !isValidVarValue(val)) { - cur = xmlNextElementSibling(cur); continue; } @@ -725,7 +723,6 @@ virNWFilterParseParamAttributes(xmlNodePtr cur) } value = NULL; } - cur = xmlNextElementSibling(cur); } return g_steal_pointer(&table); -- 2.47.2