From 4abed0d05b696a86f4b25bbd7f4422f1f28de5b0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Tue, 24 Sep 2019 14:51:49 +0200 Subject: [PATCH] Revert "nsrep: allow inclusion of good nameservers if there's space in selection" This reverts commit 196ebd4f0b3a55830b1e313fa82abfd8c290eedd. It was buggy, and I can't simply recover the intended effect. --- lib/nsrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nsrep.c b/lib/nsrep.c index 77ef7b802..c8181318f 100644 --- a/lib/nsrep.c +++ b/lib/nsrep.c @@ -257,7 +257,7 @@ static int eval_nsrep(const knot_dname_t *owner, const pack_t *addr_set, struct update_nsrep_set(ns, owner, addr_choice, score); ns->reputation = reputation; return 1; /* Stop evaluation */ - } else if (ns->score > KR_NS_MAX_SCORE || addr_choice[KR_NSREP_MAXADDR - 1] == NULL) { + } else if (ns->score > KR_NS_MAX_SCORE) { /* Check if any server was already selected. * If no, pick current server and continue evaluation. */ update_nsrep_set(ns, owner, addr_choice, score); -- 2.47.2