From 4af8ab2cab69c6ed87ca5553bfe082506325a6d8 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 31 Jan 2020 23:23:44 +0900 Subject: [PATCH] user-util: fix use after free() on error path Fixes CID#1412356. --- src/basic/user-util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/basic/user-util.c b/src/basic/user-util.c index 68c6dd0da78..6d22fe31c3d 100644 --- a/src/basic/user-util.c +++ b/src/basic/user-util.c @@ -496,11 +496,9 @@ int getgroups_alloc(gid_t** gids) { free(allocated); - allocated = new(gid_t, ngroups); + p = allocated = new(gid_t, ngroups); if (!allocated) return -ENOMEM; - - p = allocated; } *gids = TAKE_PTR(p); -- 2.47.3