From 4b1ec66cde6ada5ff4fc018f17a6ae887c0b72af Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 7 Mar 2018 09:43:30 -0500 Subject: [PATCH] qemu: Fix memory leak in qemuConnectGetAllDomainStats error path If we return -1 on VIR_ALLOC_N failure, we leaked @vms, so goto cleanup instead. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9e715e7a00..e13544f832 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20348,7 +20348,7 @@ qemuConnectGetAllDomainStats(virConnectPtr conn, } if (VIR_ALLOC_N(tmpstats, nvms + 1) < 0) - return -1; + goto cleanup; if (qemuDomainGetStatsNeedMonitor(stats)) privflags |= QEMU_DOMAIN_STATS_HAVE_JOB; -- 2.47.2