From 4b61d7652164786786c4b154e2903929281fd09e Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Wed, 23 Mar 2022 16:57:27 -0500 Subject: [PATCH] x86: Remove strpbrk-sse2.S and use the generic implementation The generic implementation is faster (see strcspn commit). All string/memory tests pass. Reviewed-by: H.J. Lu (cherry picked from commit 653358535280a599382cb6c77538a187dac6a87f) --- .../x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} | 9 ++++----- sysdeps/x86_64/strpbrk.S | 3 --- 2 files changed, 4 insertions(+), 8 deletions(-) rename sysdeps/x86_64/multiarch/{strpbrk-sse2.S => strpbrk-sse2.c} (84%) delete mode 100644 sysdeps/x86_64/strpbrk.S diff --git a/sysdeps/x86_64/multiarch/strpbrk-sse2.S b/sysdeps/x86_64/multiarch/strpbrk-sse2.c similarity index 84% rename from sysdeps/x86_64/multiarch/strpbrk-sse2.S rename to sysdeps/x86_64/multiarch/strpbrk-sse2.c index d537b6c27be..d03214c4fbb 100644 --- a/sysdeps/x86_64/multiarch/strpbrk-sse2.S +++ b/sysdeps/x86_64/multiarch/strpbrk-sse2.c @@ -1,4 +1,4 @@ -/* strpbrk optimized with SSE2. +/* strpbrk. Copyright (C) 2017-2022 Free Software Foundation, Inc. This file is part of the GNU C Library. @@ -19,11 +19,10 @@ #if IS_IN (libc) # include -# define strcspn __strpbrk_sse2 +# define STRPBRK __strpbrk_sse2 # undef libc_hidden_builtin_def -# define libc_hidden_builtin_def(strpbrk) +# define libc_hidden_builtin_def(STRPBRK) #endif -#define USE_AS_STRPBRK -#include +#include diff --git a/sysdeps/x86_64/strpbrk.S b/sysdeps/x86_64/strpbrk.S deleted file mode 100644 index 21888a5b923..00000000000 --- a/sysdeps/x86_64/strpbrk.S +++ /dev/null @@ -1,3 +0,0 @@ -#define strcspn strpbrk -#define USE_AS_STRPBRK -#include -- 2.47.2