From 4b6eed2cf7f5263bae60399da8d6542158ffff63 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Mon, 19 Feb 2018 16:43:22 -0500 Subject: [PATCH] Remove erroneous skip message The logic here seems to try to say something different when __backend__ is True but it produces a nonsensical message, since __only_on__ doesn't tell us about the implementation we are actually running. Cross-ported from SQLAlchemy, same change id. Change-Id: I14e20cadcba975f8efe8fdefa439c8b8c480b3ed --- alembic/testing/plugin/plugin_base.py | 32 ++++++++++++--------------- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/alembic/testing/plugin/plugin_base.py b/alembic/testing/plugin/plugin_base.py index 83b30e38..81584230 100644 --- a/alembic/testing/plugin/plugin_base.py +++ b/alembic/testing/plugin/plugin_base.py @@ -525,24 +525,20 @@ def _do_skips(cls): ) if not all_configs: - if getattr(cls, '__backend__', False): - msg = "'%s' unsupported for implementation '%s'" % ( - cls.__name__, cls.__only_on__) - else: - msg = "'%s' unsupported on any DB implementation %s%s" % ( - cls.__name__, - ", ".join( - "'%s(%s)+%s'" % ( - config_obj.db.name, - ".".join( - str(dig) for dig in - config_obj.db.dialect.server_version_info), - config_obj.db.driver - ) - for config_obj in config.Config.all_configs() - ), - ", ".join(reasons) - ) + msg = "'%s' unsupported on any DB implementation %s%s" % ( + cls.__name__, + ", ".join( + "'%s(%s)+%s'" % ( + config_obj.db.name, + ".".join( + str(dig) for dig in + config_obj.db.dialect.server_version_info), + config_obj.db.driver + ) + for config_obj in config.Config.all_configs() + ), + ", ".join(reasons) + ) raise SkipTest(msg) elif hasattr(cls, '__prefer_backends__'): non_preferred = set() -- 2.47.2