From 4bbd58ac804f36ab200e4e659a78a91af83d50a1 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Thu, 5 Nov 2020 00:58:21 -0800
Subject: [PATCH] clang-tidy: use const reference

Found with performance-for-range-copy

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 pdns/opensslsigners.cc |  2 +-
 pdns/pdnsutil.cc       |  8 ++++----
 pdns/ws-auth.cc        | 12 ++++++------
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/pdns/opensslsigners.cc b/pdns/opensslsigners.cc
index f2e319a9a7..e47e2705f1 100644
--- a/pdns/opensslsigners.cc
+++ b/pdns/opensslsigners.cc
@@ -288,7 +288,7 @@ DNSCryptoKeyEngine::storvector_t OpenSSLRSADNSCryptoKeyEngine::convertToISCVecto
   }
   storvect.push_back(make_pair("Algorithm", algorithm));
 
-  for(outputs_t::value_type value :  outputs) {
+  for(const outputs_t::value_type& value :  outputs) {
     std::string tmp;
     tmp.resize(BN_num_bytes(value.second));
     int len = BN_bn2bin(value.second, reinterpret_cast<unsigned char*>(&tmp.at(0)));
diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 19eb368a8e..a1fed7739c 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -224,7 +224,7 @@ static bool rectifyAllZones(DNSSECKeeper &dk, bool quiet = false)
   bool result = true;
 
   B.getAllDomains(&domainInfo);
-  for(DomainInfo di :  domainInfo) {
+  for(const DomainInfo& di :  domainInfo) {
     if (!quiet) {
       cerr<<"Rectifying "<<di.zone<<": ";
     }
@@ -1824,7 +1824,7 @@ static bool showZone(DNSSECKeeper& dk, const DNSName& zone, bool exportDS = fals
       cout << "keys: "<<endl;
     }
 
-    for(DNSSECKeeper::keyset_t::value_type value :  keyset) {
+    for(const DNSSECKeeper::keyset_t::value_type& value :  keyset) {
       string algname = DNSSECKeeper::algorithm2name(value.first.d_algorithm);
       if (!exportDS) {
         cout<<"ID = "<<value.second.id<<" ("<<DNSSECKeeper::keyTypeToString(value.second.keyType)<<")";
@@ -2751,7 +2751,7 @@ try
     B.getAllDomains(&domainInfo);
 
     unsigned int zonesSecured=0, zoneErrors=0;
-    for(DomainInfo di :  domainInfo) {
+    for(const DomainInfo& di :  domainInfo) {
       if(!dk.isSecuredZone(di.zone)) {
         cout<<"Securing "<<di.zone<<": ";
         if (secureZone(dk, di.zone)) {
@@ -3215,7 +3215,7 @@ try
        return 1;
      }
      bool found = false;
-     for(std::string tmpname :  meta) {
+     for(const std::string& tmpname :  meta) {
           if (tmpname == name) { found = true; break; }
      }
      if (!found) meta.push_back(name);
diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index 1a136da982..5ff8b79ba6 100644
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -562,7 +562,7 @@ static void gatherComments(const Json container, const DNSName& qname, const QTy
   c.qtype = qtype;
 
   time_t now = time(nullptr);
-  for (auto comment : container["comments"].array_items()) {
+  for (const auto& comment : container["comments"].array_items()) {
     c.modified_at = intFromJson(comment, "modified_at", now);
     c.content = stringFromJson(comment, "content");
     c.account = stringFromJson(comment, "account");
@@ -607,7 +607,7 @@ static void extractDomainInfoFromDocument(const Json document, boost::optional<D
 
   if (document["masters"].is_array()) {
     masters = vector<ComboAddress>();
-    for(auto value : document["masters"].array_items()) {
+    for(const auto& value : document["masters"].array_items()) {
       string master = value.string_value();
       if (master.empty())
         throw ApiException("Master can not be an empty string");
@@ -795,7 +795,7 @@ static void updateDomainSettingsFromDocument(UeberBackend& B, const DomainInfo&
 
   if (!document["master_tsig_key_ids"].is_null()) {
     vector<string> metadata;
-    for(auto value : document["master_tsig_key_ids"].array_items()) {
+    for(const auto& value : document["master_tsig_key_ids"].array_items()) {
       auto keyname(apiZoneIdToName(value.string_value()));
       DNSName keyAlgo;
       string keyContent;
@@ -811,7 +811,7 @@ static void updateDomainSettingsFromDocument(UeberBackend& B, const DomainInfo&
   }
   if (!document["slave_tsig_key_ids"].is_null()) {
     vector<string> metadata;
-    for(auto value : document["slave_tsig_key_ids"].array_items()) {
+    for(const auto& value : document["slave_tsig_key_ids"].array_items()) {
       auto keyname(apiZoneIdToName(value.string_value()));
       DNSName keyAlgo;
       string keyContent;
@@ -916,7 +916,7 @@ static void apiZoneMetadata(HttpRequest* req, HttpResponse *resp) {
 
     for (const auto& i : md) {
       Json::array entries;
-      for (string j : i.second)
+      for (const string& j : i.second)
         entries.push_back(j);
 
       Json::object key {
@@ -1657,7 +1657,7 @@ static void apiServerZones(HttpRequest* req, HttpResponse* resp) {
     }
 
     // create NS records if nameservers are given
-    for (auto value : nameservers.array_items()) {
+    for (const auto& value : nameservers.array_items()) {
       const string& nameserver = value.string_value();
       if (nameserver.empty())
         throw ApiException("Nameservers must be non-empty strings");
-- 
2.47.2