From 4c6b74e1e8dfe3ebe681f5be9a5dd7d684e285c7 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Wed, 28 May 2025 18:21:17 +0200 Subject: [PATCH] cmake: fix missed version number for multi-pkg-config detections It broke cmake builds with OpenSSL 3.5.0 and ngtcp2 1.12.0 or newer, when detected via `pkg-config`. For brotli, mbedtls, LDAP, ngtcp2 builds, it caused their version numbers missing from the configure log when detected via `pkg-config`. Regression from 01e45f81bddb2fef27fe35b7dd32032062a183f6 #16980 Regression from 3b501976a9adcf20218ffb96d9041806432227e4 #16479 Bug: https://github.com/curl/curl/pull/16980#issuecomment-2916811388 Reported-by: x-xiang on github Closes #17476 --- CMake/FindBrotli.cmake | 1 + CMake/FindLDAP.cmake | 1 + CMake/FindMbedTLS.cmake | 1 + CMake/FindNGTCP2.cmake | 1 + 4 files changed, 4 insertions(+) diff --git a/CMake/FindBrotli.cmake b/CMake/FindBrotli.cmake index 5b280dd3fe..690b5a9c27 100644 --- a/CMake/FindBrotli.cmake +++ b/CMake/FindBrotli.cmake @@ -51,6 +51,7 @@ endif() if(BROTLI_FOUND) set(Brotli_FOUND TRUE) + set(BROTLI_VERSION "${BROTLI_libbrotlicommon_VERSION}") string(REPLACE ";" " " BROTLI_CFLAGS "${BROTLI_CFLAGS}") message(STATUS "Found Brotli (via pkg-config): ${BROTLI_INCLUDE_DIRS} (found version \"${BROTLI_VERSION}\")") else() diff --git a/CMake/FindLDAP.cmake b/CMake/FindLDAP.cmake index bebad673cb..fdc6d7be94 100644 --- a/CMake/FindLDAP.cmake +++ b/CMake/FindLDAP.cmake @@ -50,6 +50,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LDAP_FOUND) + set(LDAP_VERSION "${LDAP_ldap_VERSION}") string(REPLACE ";" " " LDAP_CFLAGS "${LDAP_CFLAGS}") message(STATUS "Found LDAP (via pkg-config): ${LDAP_INCLUDE_DIRS} (found version \"${LDAP_VERSION}\")") else() diff --git a/CMake/FindMbedTLS.cmake b/CMake/FindMbedTLS.cmake index d5af4d6e77..fcd6afb3ab 100644 --- a/CMake/FindMbedTLS.cmake +++ b/CMake/FindMbedTLS.cmake @@ -59,6 +59,7 @@ endif() if(MBEDTLS_FOUND) set(MbedTLS_FOUND TRUE) + set(MBEDTLS_VERSION "${MBEDTLS_mbedtls_VERSION}") string(REPLACE ";" " " MBEDTLS_CFLAGS "${MBEDTLS_CFLAGS}") message(STATUS "Found MbedTLS (via pkg-config): ${MBEDTLS_INCLUDE_DIRS} (found version \"${MBEDTLS_VERSION}\")") else() diff --git a/CMake/FindNGTCP2.cmake b/CMake/FindNGTCP2.cmake index eb1185635e..3cbd408c22 100644 --- a/CMake/FindNGTCP2.cmake +++ b/CMake/FindNGTCP2.cmake @@ -77,6 +77,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(NGTCP2_FOUND) + set(NGTCP2_VERSION "${NGTCP2_libngtcp2_VERSION}") string(REPLACE ";" " " NGTCP2_CFLAGS "${NGTCP2_CFLAGS}") message(STATUS "Found NGTCP2 (via pkg-config): ${NGTCP2_INCLUDE_DIRS} (found version \"${NGTCP2_VERSION}\")") else() -- 2.47.3