From 4d80db59de9c7b52f75d8f32005dafc8d64658b0 Mon Sep 17 00:00:00 2001 From: Ingyu Jang Date: Fri, 15 May 2026 04:32:14 +0900 Subject: [PATCH] error-inject: use IS_ERR() check for debugfs_create_file() debugfs_create_file() returns an error pointer on failure, never NULL, so the !file check in ei_debugfs_init() never triggers and the debugfs_remove() cleanup cannot run. Use IS_ERR() and propagate the actual error via PTR_ERR(). Link: https://lore.kernel.org/20260514193214.2432769-1-ingyujang25@korea.ac.kr Signed-off-by: Ingyu Jang Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- lib/error-inject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/error-inject.c b/lib/error-inject.c index f3d1b70be605c..32f3d1ca9ea23 100644 --- a/lib/error-inject.c +++ b/lib/error-inject.c @@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void) dir = debugfs_create_dir("error_injection", NULL); file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops); - if (!file) { + if (IS_ERR(file)) { debugfs_remove(dir); - return -ENOMEM; + return PTR_ERR(file); } return 0; -- 2.47.3